linux-kernel - Re: [PATCH] xen: check return value of xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <561FD717.9090807@citrix.com>
Date:	Thu, 15 Oct 2015 17:40:55 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Insu Yun <wuninsu@...il.com>, <dmitry.torokhov@...il.com>,
	<wei.liu2@...rix.com>, <julien.grall@...rix.com>,
	<stefano.stabellini@...citrix.com>, <huaixin.chx@...baba-inc.com>,
	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:	<taesoo@...ech.edu>, <yeongjin.jang@...ech.edu>, <insu@...ech.edu>
Subject: Re: [PATCH] xen: check return value of xenbus_printf

On 15/10/15 17:25, Insu Yun wrote:
> Internally, xenbus_printf uses memory allocation, so it can be failed in
> memory pressure.Therefore, xenbus_printf's return should be checked 
> and properly handled.
[...]
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -129,8 +129,11 @@ static int xenkbd_probe(struct xenbus_device *dev,
>  
>  	if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-abs-pointer", "%d", &abs) < 0)
>  		abs = 0;
> -	if (abs)
> -		xenbus_printf(XBT_NIL, dev->nodename, "request-abs-pointer", "1");
> +	if (abs) {
> +		ret = xenbus_printf(XBT_NIL, dev->nodename, "request-abs-pointer", "1");
> +		if (ret)
> +			pr_warning("xenkbd: can't request abs-pointer");

I think you want abs = 0 here or input device will be configured as
absolute but the backend will supply relative coordinates.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/