linux-kernel - Re: [PATCH] staging: octeon: fixed few coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <561FDB37.3040602@caviumnetworks.com>
Date:	Thu, 15 Oct 2015 09:58:31 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Sakshi Bansal <sakshi.april5@...il.com>,
	<devel@...verdev.osuosl.org>, <helen.fornazier@...il.com>,
	Paul Martin <paul.martin@...ethink.co.uk>, <arnd@...db.de>,
	<david.daney@...ium.com>, <janne.huttunen@...ia.com>,
	<gregkh@...uxfoundation.org>, <jtk54@...nell.edu>,
	<linux-kernel@...r.kernel.org>, <ralf@...ux-mips.org>,
	<aaro.koskinen@...ia.com>, <jamie.lawler@...il.com>,
	<joe@...ches.com>, <robertoxmed@...il.com>,
	<okash.khawaja@...il.com>
Subject: Re: [PATCH] staging: octeon: fixed few coding style warnings

On 10/15/2015 06:40 AM, Dan Carpenter wrote:
> On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote:
>> and make sure you don't break the driver.
>
> I'm not seeing how this patch breaks anything?  What am I missing?

Did you apply it and then compile the result?  If not, then how can you 
assert that it does not break anything?

 From SubmitChecklist item #2: "Builds cleanly ..."

I don't want to waste time considering patches that don't, at a minimum, 
meet this criterion.  Other people may want to do the build testing, but 
I prefer that the patch submitter at least vet the patch enough that 
they can assert that it still builds cleanly.

David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/