linux-kernel - Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <585048FA-B498-4F84-AC09-642D95D7E8D9@goldelico.com>
Date:	Thu, 15 Oct 2015 19:16:27 +0200
From:	"H. Nikolaus Schaller" <hns@...delico.com>
To:	Nathan Lynch <Nathan_Lynch@...tor.com>
Cc:	Szabolcs Nagy <szabolcs.nagy@....com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Will Deacon <will.deacon@....com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	marek@...delico.com
Subject: Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h


Am 15.10.2015 um 19:07 schrieb Nathan Lynch <Nathan_Lynch@...tor.com>:

> On 10/15/2015 12:52 AM, H. Nikolaus Schaller wrote:
>> Am 14.10.2015 um 16:16 schrieb Nathan Lynch <nathan_lynch@...tor.com>:
>>> and it would be easier for me to deal with a patch that isn't
>>> whitespace-damaged.
>> 
>> You mean:
>> 
>> ERROR: space prohibited before that close parenthesis ')'
>> #46: FILE: arch/arm/vdso/vdsomunge.c:64:
>> +		(((unsigned short)(x) & (unsigned short)0xff00U) >> 8) ))
>> 
>> ERROR: space prohibited before that close parenthesis ')'
>> #53: FILE: arch/arm/vdso/vdsomunge.c:71:
>> +		(((unsigned int)(x) & (unsigned int)0xff000000UL) >> 24) ))
>> 
>> Well, I had copied that verbatim from arch/mips/boot/elf2ecoff.c and
>> thought that it is better readable, but it is easy to fix.
> 
> That's not what I was referring to, but it is fine to fix that too.
> 
> What I meant was that the first column of the patch body is corrupted.
> Your v2 has hunks like this (bad):
> 
> static Elf32_Word read_elf_word(Elf32_Word word, bool swap)
> {
> -	return swap ? bswap_32(word) : word;
> +	return swap ? swab32(word) : word;
> }
> 
> 
> Your v3 has this (good):
> 
> static void write_elf_word(Elf32_Word val, Elf32_Word *dst, bool swap)
> {
> -	*dst = swap ? bswap_32(val) : val;
> +	*dst = swap ? swab32(val) : val;
> }

Does this mean it is ok now in V3 in all cases? I have switched my patch editor
tool from indirect git imap-send to git send-email (which appears to be more
compatible).

BR and thanks,
Nikolaus Schaller

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/