linux-kernel - Re: [PATCH] mxl111sf: missing return values validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOcJUbxeaHRTy_YaE7CbYAFacHj4SeHSEQPJ2P2RMk6CsFEZnQ@mail.gmail.com>
Date:	Thu, 15 Oct 2015 17:27:47 -0400
From:	Michael Ira Krufky <mkrufky@...uxtv.org>
To:	Insu Yun <wuninsu@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-media <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, taesoo@...ech.edu,
	yeongjin.jang@...ech.edu, insu@...ech.edu
Subject: Re: [PATCH] mxl111sf: missing return values validation

On Thu, Oct 15, 2015 at 4:22 PM, Insu Yun <wuninsu@...il.com> wrote:
> Return values of mxl111sf_enable_usb_output and mxl1x1sf_top_master_ctrl
> are not validated.
>
> Signed-off-by: Insu Yun <wuninsu@...il.com>



Eeek!  You're right!  ...and I'm the one who wrote the offending code.
My bad O:-)

Thank you for this patch.  Mauro, please apply it.

Reviewed-by: Michael Ira Krufky <mkrufky@...uxtv.org>



> ---
>  drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> index bec12b0..b71b2e6 100644
> --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> @@ -288,9 +288,9 @@ static int mxl111sf_adap_fe_init(struct dvb_frontend *fe)
>         err = mxl1x1sf_set_device_mode(state, adap_state->device_mode);
>
>         mxl_fail(err);
> -       mxl111sf_enable_usb_output(state);
> +       err = mxl111sf_enable_usb_output(state);
>         mxl_fail(err);
> -       mxl1x1sf_top_master_ctrl(state, 1);
> +       err = mxl1x1sf_top_master_ctrl(state, 1);
>         mxl_fail(err);
>
>         if ((MXL111SF_GPIO_MOD_DVBT != adap_state->gpio_mode) &&
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/