lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Oct 2015 23:32:18 -0700 (PDT) From: David Miller <davem@...emloft.net> To: wuninsu@...il.com Cc: ian.campbell@...rix.com, wei.liu2@...rix.com, xen-devel@...ts.xenproject.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu Subject: Re: [PATCH] xen-netback: corretly check failed allocation From: Insu Yun <wuninsu@...il.com> Date: Thu, 15 Oct 2015 12:26:16 -0400 > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun <wuninsu@...il.com> > --- > drivers/net/xen-netback/xenbus.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c > index 929a6e7..e288246 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -788,6 +788,11 @@ static void connect(struct backend_info *be) > /* Use the number of queues requested by the frontend */ > be->vif->queues = vzalloc(requested_num_queues * > sizeof(struct xenvif_queue)); > + if (!be->vif->queues) { > + xenbus_dev_fatal(dev, -ENOMEM, "allocating queues"); > + return; > + } This is definitely not indented correctly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists