linux-kernel - Re: [PATCH v3] mmc: core: Fix init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 10:25:52 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Chaotian Jing <chaotian.jing@...iatek.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Johan Rudholm <johan.rudholm@...s.com>,
	Gwendal Grignou <gwendal@...omium.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-mediatek@...ts.infradead.org,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v3] mmc: core: Fix init_card in 52Mhz

On 12 October 2015 at 11:22, Chaotian Jing <chaotian.jing@...iatek.com> wrote:
> Suppose that we got a data crc error, and it triggers the mmc_reset.
> mmc_reset will call mmc_send_status to see if HW reset was supported.
> before issue CMD13, it will do retune, and if EMMC was in HS400 mode,
> it will reduce frequency to 52Mhz firstly, then results in card init
> was doing at 52Mhz.
> The mmc_send_status was originally only done for mmc_test, should drop
> it. And, rename the "eMMC hardware reset" to "Reset test", as we would
> also be able to use the test for SD-cards.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@...iatek.com>
> Suggested-by: Adrian Hunter <adrian.hunter@...el.com>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/card/mmc_test.c | 9 +++------
>  drivers/mmc/core/mmc.c      | 7 -------
>  2 files changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
> index b78cf5d..7fc9174 100644
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -2263,15 +2263,12 @@ static int mmc_test_profile_sglen_r_nonblock_perf(struct mmc_test_card *test)
>  /*
>   * eMMC hardware reset.
>   */
> -static int mmc_test_hw_reset(struct mmc_test_card *test)
> +static int mmc_test_reset(struct mmc_test_card *test)
>  {
>         struct mmc_card *card = test->card;
>         struct mmc_host *host = card->host;
>         int err;
>
> -       if (!mmc_card_mmc(card) || !mmc_can_reset(card))
> -               return RESULT_UNSUP_CARD;
> -
>         err = mmc_hw_reset(host);
>         if (!err)
>                 return RESULT_OK;
> @@ -2605,8 +2602,8 @@ static const struct mmc_test_case mmc_test_cases[] = {
>         },
>
>         {
> -               .name = "eMMC hardware reset",
> -               .run = mmc_test_hw_reset,
> +               .name = "Reset test",
> +               .run = mmc_test_reset,
>         },
>  };
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index e726903..f6cd995 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1924,7 +1924,6 @@ EXPORT_SYMBOL(mmc_can_reset);
>  static int mmc_reset(struct mmc_host *host)
>  {
>         struct mmc_card *card = host->card;
> -       u32 status;
>
>         if (!(host->caps & MMC_CAP_HW_RESET) || !host->ops->hw_reset)
>                 return -EOPNOTSUPP;
> @@ -1937,12 +1936,6 @@ static int mmc_reset(struct mmc_host *host)
>
>         host->ops->hw_reset(host);
>
> -       /* If the reset has happened, then a status command will fail */
> -       if (!mmc_send_status(card, &status)) {
> -               mmc_host_clk_release(host);
> -               return -ENOSYS;
> -       }
> -
>         /* Set initial state and call mmc_set_ios */
>         mmc_set_initial_state(host);
>         mmc_host_clk_release(host);
> --
> 1.8.1.1.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/