linux-kernel - Re: [PATCH] arm64: change to use memmove in efi-stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151016105716.GB975@leverpostej>
Date:	Fri, 16 Oct 2015 11:57:17 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	yalin wang <yalin.wang2010@...il.com>
Cc:	catalin.marinas@....com, will.deacon@....com,
	ard.biesheuvel@...aro.org, matt.fleming@...el.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: change to use memmove in efi-stub

Hi,

On Fri, Oct 16, 2015 at 06:46:07PM +0800, yalin wang wrote:
> Change to use memmove(), in case the dest address overlap with the
> source address.

This cannot happen, and memove would not be sufficient if it did.

The destination is a region returned by EFI_BOOT_SERVICES.AllocatePages,
which can only allocate pages which were free to begin with. Therefore
the new region cannot overlap with the stub (whose pages are not free).

Were the new region to overlap with the stub, the memmove could corrupt
the code/data in use by the stub, and things would explode shortly
thereafter.

Thanks,
Mark.

> 
> Signed-off-by: yalin wang <yalin.wang2010@...il.com>
> ---
>  arch/arm64/kernel/efi-stub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/efi-stub.c b/arch/arm64/kernel/efi-stub.c
> index 816120e..b6dc44b 100644
> --- a/arch/arm64/kernel/efi-stub.c
> +++ b/arch/arm64/kernel/efi-stub.c
> @@ -59,7 +59,7 @@ efi_status_t __init handle_kernel_image(efi_system_table_t *sys_table_arg,
>  			}
>  			*image_addr = *reserve_addr + TEXT_OFFSET;
>  		}
> -		memcpy((void *)*image_addr, old_image_addr, kernel_size);
> +		memmove((void *)*image_addr, old_image_addr, kernel_size);
>  		*reserve_size = kernel_memsize;
>  	}
>  
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/