linux-kernel - Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9667302.4m5v3ViVSt@wuerfel>
Date:	Fri, 16 Oct 2015 13:28:04 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	David Laight <David.Laight@...lab.com>
Cc:	huangdaode <huangdaode@...ilicon.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"joe@...ches.com" <joe@...ches.com>,
	"liguozhu@...ilicon.com" <liguozhu@...ilicon.com>,
	"Yisen.Zhuang@...wei.com" <Yisen.Zhuang@...wei.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linuxarm@...wei.com" <linuxarm@...wei.com>,
	"salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"kenneth-lee-2012@...mail.com" <kenneth-lee-2012@...mail.com>,
	"xuwei5@...ilicon.com" <xuwei5@...ilicon.com>,
	"lisheng011@...wei.com" <lisheng011@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lipeng321@...wei.com" <lipeng321@...wei.com>
Subject: Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

On Friday 16 October 2015 11:14:44 David Laight wrote:
> From: Arnd Bergmann
> > Sent: 16 October 2015 11:01
> > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that
> > has bits set that do not fit into a 32-bit variable on 64-bit architectures,
> > which causes a harmless gcc warning:
> ...
> >  static void hix5hd2_port_disable(struct hix5hd2_priv *priv)
> >  {
> > -     writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN);
> > +     writel_relaxed(~(u32)(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN);
> >       writel_relaxed(0, priv->base + DESC_WR_RD_ENA);
> 
> ISTM that just means that the constants shouldn't be 'long'.

Right, but that would probably mean changing the BIT() macro or not using it
here. In the past I've argued against using that macro, but I've given
up that fight.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/