linux-kernel - Re: [REPOST PATCH] ftrace: Calculate the correct dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151015222545.45a22b7e@grimm.local.home>
Date:	Thu, 15 Oct 2015 22:25:45 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Minfei Huang <mnfhuang@...il.com>
Cc:	mingo@...hat.com, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org, mhuang@...hat.com,
	rostedt@...dmis.org
Subject: Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number
 to report to the userspace

On Thu, 17 Sep 2015 00:19:42 +0800
Minfei Huang <mnfhuang@...il.com> wrote:

> Now, ftrace only calculate the dyn_ftrace number in the adding
> breakpoint loop, not in adding update and finish update loop.
> 
> Calculate the correct dyn_ftrace, once ftrace reports the failure message
> to the userspace.
> 

Bah, your emails got lost in my Inbox. Sorry about that.

I'll make an effort to look at this first thing tomorrow.

[ Cc'ing myself to remind me ]

-- Steve

> Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> ---
>  arch/x86/kernel/ftrace.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 8b7b0a5..311bcf3 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -556,6 +556,7 @@ void ftrace_replace_code(int enable)
>  	run_sync();
>  
>  	report = "updating code";
> +	count = 0;
>  
>  	for_ftrace_rec_iter(iter) {
>  		rec = ftrace_rec_iter_record(iter);
> @@ -563,11 +564,13 @@ void ftrace_replace_code(int enable)
>  		ret = add_update(rec, enable);
>  		if (ret)
>  			goto remove_breakpoints;
> +		count++;
>  	}
>  
>  	run_sync();
>  
>  	report = "removing breakpoints";
> +	count = 0;
>  
>  	for_ftrace_rec_iter(iter) {
>  		rec = ftrace_rec_iter_record(iter);
> @@ -575,6 +578,7 @@ void ftrace_replace_code(int enable)
>  		ret = finish_update(rec, enable);
>  		if (ret)
>  			goto remove_breakpoints;
> +		count++;
>  	}
>  
>  	run_sync();

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/