linux-kernel - Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3757591.KXgD8p0a1E@wuerfel>
Date:	Fri, 16 Oct 2015 14:55:38 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	John Garry <john.garry@...wei.com>
Cc:	James.Bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linuxarm@...wei.com, zhangfei.gao@...aro.org,
	linux-scsi@...r.kernel.org, xuwei5@...ilicon.com,
	john.garry2@...l.dcu.ie, hare@...e.de
Subject: Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

On Monday 12 October 2015 23:20:25 John Garry wrote:
> @@ -804,6 +818,16 @@ static irqreturn_t int_phyup_v1_hw(int irq_no, void *p)
>                 phy->identify.target_port_protocols =
>                         SAS_PROTOCOL_SMP;
>  
> +       wq = kmalloc(sizeof(*wq), GFP_ATOMIC);
> +       if (!wq)
> +               goto end;
> +
> +       wq->event = PHYUP;
> +       wq->hisi_hba = hisi_hba;
> +       wq->phy_no = phy_no;
> +
> +       INIT_WORK(&wq->work_struct, hisi_sas_wq_process);
> +       queue_work(hisi_hba->wq, &wq->work_struct);
>  
>  end:
>         hisi_sas_phy_write32(hisi_hba, phy_no, CHL_INT2,
> 

While rereading some other parts of the code, I stumbled over this piece.
You should generally not allocate work structs dynamically. Why not embed
the work struct inside of the phy structure and then just queue that?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/