linux-kernel - Re: [PATCH] clk: Make of_clk_get_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUtxQfkc=a3ObbDserFtSyAPAKvAbywzSFoQZXd7kh=HQ@mail.gmail.com>
Date:	Fri, 16 Oct 2015 15:02:37 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Michael Turquette <mturquette@...libre.com>
Cc:	Stephen Boyd <sboyd@...eaurora.org>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-clk <linux-clk@...r.kernel.org>,
	"Gregory CLEMENT <gregory.clement@...e-electrons.com>, Jason Cooper
	<jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>, Sebastian
	Hesselbarth" <sebastian.hesselbarth@...il.com>,
	Magnus Damm <magnus.damm@...il.com>
Subject: Re: [PATCH] clk: Make of_clk_get_parent_name() robust with
 #clock-cells = 1

Hi Mike,

On Fri, Oct 16, 2015 at 2:55 PM, Michael Turquette
<mturquette@...libre.com> wrote:
> Quoting Stephen Boyd (2015-10-15 16:19:38)
>> If a clock provider has #clock-cells = 1 and we call
>> of_clk_get_parent_name() on it we may end up returning the name
>> of the provider node if the provider doesn't have a
>> clock-output-names property. This doesn't make sense, especially
>> when you consider that calling of_clk_get_parent_name() on such a
>> node with different indices will return the same name each time.
>>
>> Let's try getting the clock from the framework via of_clk_get()
>> instead, and only fallback to the node name if we have a provider
>> with #clock-cells = 0. This way, we can't hand out the same name
>> for different clocks when we don't actually know their names.
>>
>> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
>
> Geert,
>
> Does this approach fix the issues you had removing clock-output-names
> from your clock provider DTS?

I already saw this patch in clk-next, and I think it would fix that issue.
However, we're no longer seeing the issue, as we no longer have
fixed-factor-clocks in DT.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/