linux-kernel - Re: [PATCH 1/2] mmc: skip reclaiming host on mmc_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpJXC2M5e_L68UXWkjEiTkyMDBNDb6CY-LuFc9043LLTA@mail.gmail.com>
Date:	Fri, 16 Oct 2015 15:07:09 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mmc: skip reclaiming host on mmc_add_card() error

On 14 October 2015 at 22:53, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> There's little sense in releasing the host on mmc_add_card() error
> immediately after reclaiming  it, so  reclaim the host  only in case
> of success.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Thanks, applied patch 1 and patch 2 (squashed them) for next.

Kind regards
Uffe

>
> ---
> The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch.
>
>  drivers/mmc/core/mmc.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: mmc/drivers/mmc/core/mmc.c
> ===================================================================
> --- mmc.orig/drivers/mmc/core/mmc.c
> +++ mmc/drivers/mmc/core/mmc.c
> @@ -2009,14 +2009,13 @@ int mmc_attach_mmc(struct mmc_host *host
>
>         mmc_release_host(host);
>         err = mmc_add_card(host->card);
> -       mmc_claim_host(host);
>         if (err)
>                 goto remove_card;
>
> +       mmc_claim_host(host);
>         return 0;
>
>  remove_card:
> -       mmc_release_host(host);
>         mmc_remove_card(host->card);
>         mmc_claim_host(host);
>         host->card = NULL;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/