linux-kernel - Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 15:36:38 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	John Garry <john.garry@...wei.com>
Cc:	James.Bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linuxarm@...wei.com, zhangfei.gao@...aro.org,
	linux-scsi@...r.kernel.org, xuwei5@...ilicon.com,
	john.garry2@...l.dcu.ie, hare@...e.de
Subject: Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

On Friday 16 October 2015 14:29:55 John Garry wrote:
> 
> It could be considered.
> 
> A potential issue I see is with hisi_sas_control_phy() for 
> PHY_FUNC_HARD_RESET: this allocates a hisi_sas_wq struct and processes 
> the reset in the queue work. When we re-enable the phy for the reset, 
> the phyup irq will want to use the same hisi_sas_wq struct which may be 
> in use.
> 
> hisi_sas_control_phy() is added in 23/35.

I'd have to review more closely, but I think that's fine, as this
is how most work queues are used: you can queue the same function
multiple times, and it's guaranteed to run at least once after
the last queue, so if you queue it while it's already running,
it will be called again, otherwise it won't.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/