linux-kernel - Re: SoCFPGA ethernet broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151016033143.GA28207@lunn.ch>
Date:	Fri, 16 Oct 2015 05:31:43 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Dinh Nguyen <dinguyen@...nsource.altera.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	David Daney <ddaney@...iumnetworks.com>,
	"David S. Miller" <davem@...emloft.net>, david.daney@...ium.com,
	netdev@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: SoCFPGA ethernet broken

> Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached
> to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when
> the call to ksz9021_config_init() is made both of_node and dev->parent->of_node
> are NULL, without the patch the dev->parent->of_node is a valid pointer. Thus
> the skew values get programmed to the phy.

Ah!

You have the phy device tree parameters in the wrong place. These are
phy paramters, so should really be in the phy node. But
socfpga_cyclone5_socdk.dts has them in the MAC node.

There is nothing in Documentation/devicetree/bindings/net/micrel.txt
which says you are allowed to place them in the MAC node. Obviously
the code did allow this, which is what has now broken.

    Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/