linux-kernel - Re: [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56211270.4040002@ti.com>
Date:	Fri, 16 Oct 2015 10:06:24 -0500
From:	"Andrew F. Davis" <afd@...com>
To:	Sebastian Reichel <sre@...nel.org>
CC:	Pali Rohár <pali.rohar@...il.com>,
	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c
 section

On 10/16/2015 08:44 AM, Sebastian Reichel wrote:
> The IRQ handler is not used by the platform based
> code resulting in a 'defined but not used' warning,
> if CONFIG_BQ27XXX_I2C is not enabled.
>
> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> ---
>   drivers/power/bq27xxx_battery.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 69e6b371a51c..880233ce9343 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -762,15 +762,6 @@ static void bq27xxx_battery_update(struct bq27xxx_device_info *di)
>   	di->last_update = jiffies;
>   }
>
> -static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
> -{
> -	struct bq27xxx_device_info *di = data;
> -
> -	bq27xxx_battery_update(di);
> -
> -	return IRQ_HANDLED;
> -}
> -
>   static void bq27xxx_battery_poll(struct work_struct *work)
>   {
>   	struct bq27xxx_device_info *di =
> @@ -1061,6 +1052,15 @@ static void bq27xxx_powersupply_unregister(struct bq27xxx_device_info *di)
>   static DEFINE_IDR(battery_id);
>   static DEFINE_MUTEX(battery_mutex);
>
> +static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
> +{
> +	struct bq27xxx_device_info *di = data;
> +
> +	bq27xxx_battery_update(di);
> +
> +	return IRQ_HANDLED;
> +}
> +
>   static int bq27xxx_battery_i2c_read(struct bq27xxx_device_info *di, u8 reg,
>   				    bool single)
>   {
>

Acked-by: Andrew F. Davis <afd@...com>

-- 
Andrew F. Davis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/