linux-kernel - Re: [PATCH v2] watchdog: Compile possible drivers with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 12:11:53 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org, wim@...ana.be,
	javier@....samsung.com,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: Re: [PATCH v2] watchdog: Compile possible drivers with COMPILE_TEST

Hi Luis,

[auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Luis-de-Bethencourt/watchdog-Compile-possible-drivers-with-COMPILE_TEST/20151015-025729
config: um-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um 

All error/warnings (new ones prefixed by >>):

   drivers/watchdog/digicolor_wdt.c: In function 'dc_wdt_probe':
>> drivers/watchdog/digicolor_wdt.c:167:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
     iounmap(wdt->base);
     ^
   cc1: some warnings being treated as errors
--
   drivers/watchdog/sc520_wdt.c: In function 'sc520_wdt_unload':
>> drivers/watchdog/sc520_wdt.c:380:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
     iounmap(wdtmrctl);
     ^
   drivers/watchdog/sc520_wdt.c: In function 'sc520_wdt_init':
>> drivers/watchdog/sc520_wdt.c:395:13: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
     wdtmrctl = ioremap(MMCR_BASE + OFFS_WDTMRCTL, 2);
                ^
>> drivers/watchdog/sc520_wdt.c:395:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     wdtmrctl = ioremap(MMCR_BASE + OFFS_WDTMRCTL, 2);
              ^
   cc1: some warnings being treated as errors

vim +/iounmap +167 drivers/watchdog/digicolor_wdt.c

336694a0 Baruch Siach 2015-03-31  151  	watchdog_init_timeout(&dc_wdt_wdd, timeout, dev);
336694a0 Baruch Siach 2015-03-31  152  	ret = watchdog_register_device(&dc_wdt_wdd);
336694a0 Baruch Siach 2015-03-31  153  	if (ret) {
336694a0 Baruch Siach 2015-03-31  154  		dev_err(dev, "Failed to register watchdog device");
336694a0 Baruch Siach 2015-03-31  155  		goto err_iounmap;
336694a0 Baruch Siach 2015-03-31  156  	}
336694a0 Baruch Siach 2015-03-31  157  
336694a0 Baruch Siach 2015-03-31  158  	wdt->restart_handler.notifier_call = dc_restart_handler;
336694a0 Baruch Siach 2015-03-31  159  	wdt->restart_handler.priority = 128;
336694a0 Baruch Siach 2015-03-31  160  	ret = register_restart_handler(&wdt->restart_handler);
336694a0 Baruch Siach 2015-03-31  161  	if (ret)
336694a0 Baruch Siach 2015-03-31  162  		dev_warn(&pdev->dev, "cannot register restart handler\n");
336694a0 Baruch Siach 2015-03-31  163  
336694a0 Baruch Siach 2015-03-31  164  	return 0;
336694a0 Baruch Siach 2015-03-31  165  
336694a0 Baruch Siach 2015-03-31  166  err_iounmap:
336694a0 Baruch Siach 2015-03-31 @167  	iounmap(wdt->base);
336694a0 Baruch Siach 2015-03-31  168  	return ret;
336694a0 Baruch Siach 2015-03-31  169  }
336694a0 Baruch Siach 2015-03-31  170  
336694a0 Baruch Siach 2015-03-31  171  static int dc_wdt_remove(struct platform_device *pdev)
336694a0 Baruch Siach 2015-03-31  172  {
336694a0 Baruch Siach 2015-03-31  173  	struct dc_wdt *wdt = platform_get_drvdata(pdev);
336694a0 Baruch Siach 2015-03-31  174  
336694a0 Baruch Siach 2015-03-31  175  	unregister_restart_handler(&wdt->restart_handler);

:::::: The code at line 167 was first introduced by commit
:::::: 336694a01dae7e788630f8043dae30337047b51b watchdog: digicolor: driver for Conexant Digicolor CX92755 SoC

:::::: TO: Baruch Siach <baruch@...s.co.il>
:::::: CC: Wim Van Sebroeck <wim@...ana.be>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (17023 bytes)