linux-kernel - Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 17:55:22 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	kernel@...gutronix.de, alkml@...gutronix.de
Subject: Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply
 regulators

On Tue, Oct 13, 2015 at 12:45:29PM +0200, Sascha Hauer wrote:

> +		best_supply_uV = regulator_get_voltage_floor(regulator, min_uV);
> +		if (best_supply_uV < 0) {
> +			ret = best_supply_uV;
> +			goto out2;
> +		}

Now I look at the user here this is just the map voltage operation.  We
could even refactor...

>  	ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
>  	if (ret < 0)
>  		goto out2;

...do_set_voltage() so that we only do the mapping once, though that
gets tricky as we still support devices that don't have mapping
configured :/ .

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)