lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151016052326.GA3226@leoy-linaro> Date: Fri, 16 Oct 2015 13:23:26 +0800 From: Leo Yan <leo.yan@...aro.org> To: Jassi Brar <jassisinghbrar@...il.com> Cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Bintian Wang <bintian.wang@...wei.com>, Yiping Xu <xuyiping@...ilicon.com>, Haojian Zhuang <haojian.zhuang@...aro.org>, Wei Xu <xuwei5@...ilicon.com>, Devicetree List <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v4 1/4] dt-bindings: mailbox: Document Hi6220 mailbox driver Hi Jassi, Thanks for review. On Fri, Oct 16, 2015 at 10:26:48AM +0530, Jassi Brar wrote: > On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan <leo.yan@...aro.org> wrote: > > > + > > +Mailbox Device Node: > > +==================== > > + > > +Required properties: > > +-------------------- > > +- compatible: Shall be "hisilicon,hi6220-mbox" > > +- reg: Contains the mailbox register address range (base > > + address and length); the first item is for IPC > > + registers, the second item is shared buffer for > > + slots. > > > Is the shared-buffer a part of mailbox controller or just regular > memory that could be used for purposes other than mailbox also? If > latter, please remove it from here. The shared-buffer is part of mailbox controller, this region cannot be dynamically allocated for other purpose; it's hardcode by MCU firmware. > > +Mailbox client > > +=============== > > + > > +"mboxes" and the optional "mbox-names" (please see > > +Documentation/devicetree/bindings/mailbox/mailbox.txt for details). Each value > > +of the mboxes property should contain a phandle to the mailbox controller > > +device node and second argument is the channel index. It must be 0 (hardware > > +support only one channel). > > > sorry, what must be 0? You have MBOX_CHAN_MAX and MBOX_CHAN_NUM as 32 > and 2 in the driver. Will fix it. Thanks, Leo Yan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists