linux-kernel - Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3951119.loGSTxYIZb@wuerfel>
Date:	Fri, 16 Oct 2015 21:06:14 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Jonathan Corbet <corbet@....net>,
	Sergei Zviagintsev <sergei@...v.net>,
	Peter Hurley <peter@...leysoftware.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Sebastian Reichel <sre@...nel.org>,
	NeilBrown <neil@...wn.name>,
	Grant Likely <grant.likely@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org, Marek Belisko <marek@...delico.com>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver

On Friday 16 October 2015 20:08:35 H. Nikolaus Schaller wrote:
> +
> +static int w2sg_data_probe(struct platform_device *pdev)
> +{
> +       struct w2sg_pdata *pdata = dev_get_platdata(&pdev->dev);
> +       struct w2sg_data *data;
> +       struct rfkill *rf_kill;
> +       int err;
> +
> +       pr_debug("%s()\n", __func__);
> +
> +       if (pdev->dev.of_node) {
> +               struct device *dev = &pdev->dev;
> +               enum of_gpio_flags flags;
> +
> +               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> +               if (!pdata)
> 

Why is this a platform_device and not a serio_device?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/