linux-kernel - Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151016192031.GB16437@codeaurora.org>
Date:	Fri, 16 Oct 2015 12:20:31 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Rafael Wysocki <rjw@...ysocki.net>, linaro-kernel@...ts.linaro.org,
	linux-pm@...r.kernel.org, nm@...com,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Dmitry Torokhov <dtor@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	open list <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt

On 10/16, Viresh Kumar wrote:
> On 15-10-15, 12:04, Stephen Boyd wrote:
> > On 10/15, Viresh Kumar wrote:
> > > With debug options on, it is difficult to locate OPP core's debug
> > > prints. Fix this by prefixing OPP debug prints with KBUILD_MODNAME.
> > > 
> > > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> > 
> > Why not use dynamic debug's m flag to turn on KBUILD_MODNAME when
> > debugging?
> > 
> > >From Documentation/dynamic-debug-howto.txt
> > 
> >   m    Include module name in the printed message
> 
> It wasn't just about debug messages but pr_info and pr_err as well.
> And so I defined pr_fmt instead.
> 

Ok, well the commit text exclusively mentions debug, leading me
to believe this is all about making the debug prints (i.e.
pr_debug) have KBUILD_MODNAME. 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/