linux-kernel - Re: [PATCH 1/2] gpiolib: Split GPIO flags parsing and GPIO configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 22:48:03 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpiolib: Split GPIO flags parsing and GPIO configuration

On Mon, Oct 12, 2015 at 11:20 PM, Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:

> When requesting a GPIO through the legacy or the gpiod_* API the
> gpiochip request operation is first called and then the GPIO flags are
> parsed and the GPIO is configured. This prevents the gpiochip from
> rejecting the request if the flags are not supported by the device.
>
> To fix this split the parse-and-configure operation in two and parse
> flags before requesting the GPIO.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Very elegant, this is exactly how we need things to happen.
Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/