linux-kernel - Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510170735.UEiJ8nd3%fengguang.wu@intel.com>
Date:	Sat, 17 Oct 2015 07:45:43 +0800
From:	kbuild test robot <lkp@...el.com>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	kbuild-all@...org, Jiri Slaby <jslaby@...e.cz>,
	Arnd Bergmann <arnd@...db.de>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Jonathan Corbet <corbet@....net>,
	Sergei Zviagintsev <sergei@...v.net>,
	Peter Hurley <peter@...leysoftware.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Sebastian Reichel <sre@...nel.org>,
	NeilBrown <neil@...wn.name>,
	Grant Likely <grant.likely@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org, Marek Belisko <marek@...delico.com>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	"H. Nikolaus Schaller" <hns@...delico.com>
Subject: Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver

Hi Nikolaus,

[auto build test WARNING on tty/tty-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/H-Nikolaus-Schaller/UART-slave-device-support-goldelico-version/20151017-021238
config: xtensa-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

>> drivers/misc/w2sg0004.c:361:12: warning: 'w2sg_data_suspend' defined but not used [-Wunused-function]
    static int w2sg_data_suspend(struct device *dev)
               ^
>> drivers/misc/w2sg0004.c:399:12: warning: 'w2sg_data_resume' defined but not used [-Wunused-function]
    static int w2sg_data_resume(struct device *dev)
               ^

vim +/w2sg_data_suspend +361 drivers/misc/w2sg0004.c

   355			uart_register_rx_notification(data->uart, NULL, NULL);
   356			uart_register_slave(data->uart, NULL);
   357		}
   358		return 0;
   359	}
   360	
 > 361	static int w2sg_data_suspend(struct device *dev)
   362	{
   363		struct w2sg_data *data = dev_get_drvdata(dev);
   364	
   365		spin_lock_irq(&data->lock);
   366		data->suspended = true;
   367		spin_unlock_irq(&data->lock);
   368	
   369		cancel_delayed_work_sync(&data->work);
   370	
   371		w2sg_data_set_lna_power(data);	/* shuts down if needed */
   372	
   373		if (data->state == W2SG_PULSE) {
   374			msleep(10);
   375			gpio_set_value_cansleep(data->on_off_gpio, 1);
   376			data->last_toggle = jiffies;
   377			data->is_on = !data->is_on;
   378			data->state = W2SG_NOPULSE;
   379		}
   380	
   381		if (data->state == W2SG_NOPULSE) {
   382			msleep(10);
   383			data->state = W2SG_IDLE;
   384		}
   385	
   386		if (data->is_on) {
   387			pr_info("GPS off for suspend %d %d %d\n", data->requested,
   388				data->is_on, data->lna_is_off);
   389	
   390			gpio_set_value_cansleep(data->on_off_gpio, 0);
   391			msleep(10);
   392			gpio_set_value_cansleep(data->on_off_gpio, 1);
   393			data->is_on = 0;
   394		}
   395	
   396		return 0;
   397	}
   398	
 > 399	static int w2sg_data_resume(struct device *dev)
   400	{
   401		struct w2sg_data *data = dev_get_drvdata(dev);
   402	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (42196 bytes)