linux-kernel - Re: [PATCH] ohci-pci: use PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151017063942.GA14187@kroah.com>
Date:	Fri, 16 Oct 2015 23:39:42 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	linux-usb@...r.kernel.org, stern@...land.harvard.edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ohci-pci: use PCI_DEVICE_SUB()

On Mon, Oct 12, 2015 at 08:31:55PM +0300, Sergei Shtylyov wrote:
> Toshiba  Portege 4000 quirk entry can be written shorter using the
> PCI_DEVICE_SUB() macro.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> ---
> The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.
> 
>  drivers/usb/host/ohci-pci.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Index: usb/drivers/usb/host/ohci-pci.c
> ===================================================================
> --- usb.orig/drivers/usb/host/ohci-pci.c
> +++ usb/drivers/usb/host/ohci-pci.c
> @@ -192,10 +192,8 @@ static const struct pci_device_id ohci_p
>  	},
>  	{
>  		/* Toshiba portege 4000 */
> -		.vendor		= PCI_VENDOR_ID_AL,
> -		.device		= 0x5237,
> -		.subvendor	= PCI_VENDOR_ID_TOSHIBA,
> -		.subdevice	= 0x0004,
> +		PCI_DEVICE_SUB(PCI_VENDOR_ID_AL, 0x5237,
> +			       PCI_VENDOR_ID_TOSHIBA, 0x0004),

But it's much less readable now, right?  Why make this change then?

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/