lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20151017004645.GD7340@mwanda>
Date:	Sat, 17 Oct 2015 03:46:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	hamohammed.sa@...il.com, paul.gortmaker@...driver.com,
	gregkh@...uxfoundation.org, gdonald@...il.com,
	cristina.opriceana@...il.com
Subject: Re: [PATCH v2] staging: rtl8192u: simplify conditional statement

On Fri, Oct 16, 2015 at 02:26:31PM +0100, Luis de Bethencourt wrote:
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index c443e2e..f85e5ff 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -466,10 +466,7 @@ void ieee80211_softmac_scan_syncro(struct ieee80211_device *ieee)
>  		/* this prevent excessive time wait when we
>  		 * need to wait for a syncro scan to end..
>  		 */
> -		if(ieee->state < IEEE80211_LINKED)
> -			;
> -		else
> -		if (ieee->sync_scan_hurryup)
> +		if (ieee->state > IEEE80211_LINKED && ieee->sync_scan_hurryup)

This should be >= instead of >.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists