linux-kernel - Re: [PATCH v4] rtc: pcf8563: add CLKOUT to common clock framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151018003050.GZ3421@piout.net>
Date:	Sun, 18 Oct 2015 02:30:50 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Heiko Schocher <hs@...x.de>
Cc:	linux-kernel@...r.kernel.org, Georg.Soffel@...ch-si.com,
	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4] rtc: pcf8563: add CLKOUT to common clock framework

On 16/10/2015 at 13:31:29 +0200, Heiko Schocher wrote :
> Add the clkout output clk to the common clock framework.
> Disable the CLKOUT of the RTC after power-up.
> After power-up/reset of the RTC, CLKOUT is enabled by default,
> with CLKOUT enabled the RTC chip has 2-3 times higher power
> consumption.
> 
> Signed-off-by: Heiko Schocher <hs@...x.de>
> ---
> 
> Changes in v4:
> - add comments from Alexandre Belloni
>   - use devm_clk_register() instead of clk_register()
>   - rework Documentation
> 
> Changes in v3:
> - use CONFIG_COMMON_CLK for common clk framework
>   changes
> 
> Changes in v2:
> - add comments from Alexandre Belloni
>   - remove the DT property, instead
>     register for the CLKOUT a clk in the common
>     clk framework. The clk is disabled by default.
> 
>  Documentation/devicetree/bindings/rtc/pcf8563.txt |  25 ++++
>  drivers/rtc/rtc-pcf8563.c                         | 170 +++++++++++++++++++++-
>  2 files changed, 194 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/