| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151018001428.GV3421@piout.net> Date: Sun, 18 Oct 2015 02:14:28 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Alessandro Zummo <a.zummo@...ertech.it>, rtc-linux@...glegroups.com, kernel@...gutronix.de, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v1 1/4] rtc: pcf2127: fix reading uninitialized value on RTC_READ_VL ioctl On 02/10/2015 at 11:17:19 +0200, Uwe Kleine-König wrote : > The flag reported on the RTC_READ_VL ioctl is only initialized when the > date is read out. So the voltage low value doesn't represent reality but > the status at the time the date was read (or 0 if the date was not read > yet). > > Moreover when userspace requests a value via an ioctl there is no added > benefit to also make a prosa representation of this (and other) values > appear in the kernel log so remove the calls to dev_info and the driver > data members to track their state. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists