| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <56236C9A.8060906@users.sourceforge.net> Date: Sun, 18 Oct 2015 11:55:38 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Julia Lawall <Julia.Lawall@...6.fr> Cc: Fabian Frederick <fabf@...net.be>, Gilles Muller <Gilles.Muller@...6.fr>, Michal Marek <mmarek@...e.com>, Nicolas Palix <nicolas.palix@...g.fr>, cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree > Remove removal and re-addition of freeing functions. I find such a wording confusing for a commit message. > Add position variable on usb_free_urb in the non-patch case. Is it interesting that this fix corresponds to a bug report from 2014-08-09? https://lkml.org/lkml/2014/8/9/33 https://systeme.lip6.fr/pipermail/cocci/2014-August/001038.html > @r depends on context || report || org @ > @@ -36,8 +32,8 @@ expression E; > position p; > @@ > > -* if (E) > -* \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E); > +* if (E != NULL) > +* \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\)(E); How do you think about to extend the shown function name pattern also with suffixes like the following (besides "destroy")? * put * release * unref * unregister Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists