linux-kernel - Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151018111536.GA7391@intel.com>
Date:	Sun, 18 Oct 2015 14:15:36 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Peter Hüwe <PeterHuewe@....de>
Cc:	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, jgunthorpe@...idianresearch.com,
	dhowells@...hat.com, artem.bityutskiy@...ux.intel.com,
	Marcel Selhorst <tpmdd@...horst.net>
Subject: Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command
 buffer address

On Sun, Oct 18, 2015 at 05:02:55AM +0200, Peter Hüwe wrote:
> Am Freitag, 16. Oktober 2015, 20:40:20 schrieb Jarkko Sakkinen:
> > +       pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) +
> > +               (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low));
> 
> The canonical form would be 
> > +       pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) |
> > +               (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low));
> ?
> Or am I missing something?
> Shall I fix-up?

Please do. Current works but definitely your form is correct.

> Thanks,
> Peter

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/