linux-kernel - Re: [PATCH] net: wireless: rt2x00: statics code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56239BA5.9080806@cogentembedded.com>
Date:	Sun, 18 Oct 2015 16:16:21 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Paul McQuade <paulmcquad@...il.com>
Cc:	sgruszka@...hat.com, helmut.schaa@...glemail.com,
	kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wireless: rt2x00: statics code style

Hello.

On 10/17/2015 11:25 PM, Paul McQuade wrote:

> Do not initialise statics to 0 or NULL
> Also use tabs where possible
>
> Signed-off-by: Paul McQuade <paulmcquad@...il.com>
> ---
>   drivers/net/wireless/rt2x00/rt61pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
> index c0e730e..53bd23d 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.c
> +++ b/drivers/net/wireless/rt2x00/rt61pci.c
> @@ -39,7 +39,7 @@
>   /*
>    * Allow hardware encryption to be disabled.
>    */
> -static bool modparam_nohwcrypt = false;
> +static bool modparam_nohwcrypt;
>   module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
>   MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
>
> @@ -1388,7 +1388,7 @@ static bool rt61pci_get_entry_state(struct queue_entry *entry)
>   		rt2x00_desc_read(entry_priv->desc, 0, &word);
>
>   		return (rt2x00_get_field32(word, TXD_W0_OWNER_NIC) ||
> -		        rt2x00_get_field32(word, TXD_W0_VALID));
> +		rt2x00_get_field32(word, TXD_W0_VALID));

    This line should indented more, like it was before. And the outer parens 
aren't needed.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/