linux-kernel - [PATCH] staging: ft1000: Remove boolean comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Oct 2015 21:58:15 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	marek.belisko@...il.com, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, gulsah.1004@...il.com, joe@...ches.com,
	daniele.alessandrelli@...il.com, mahfouz.saif.elyazal@...il.com,
	rickard_strandqvist@...ctrumdigital.se,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [PATCH] staging: ft1000: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false.

Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
 drivers/staging/ft1000/ft1000-usb/ft1000_hw.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index eecfa37..dfb5da93 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -1531,7 +1531,7 @@ static int ft1000_copy_up_pkt(struct net_device *dev)
 			tempword = ft1000_read_reg(dev, FT1000_REG_DFIFO);
 			*pbuffer++ = (u8) (tempword >> 8);
 			*pbuffer++ = (u8)tempword;
-			if (ft1000_chkcard(dev) == false) {
+			if (!ft1000_chkcard(dev)) {
 				kfree_skb(skb);
 				return FAILURE;
 			}
@@ -1822,7 +1822,7 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
 		return IRQ_HANDLED;
 	}
 
-	if (ft1000_chkcard(dev) == false) {
+	if (!ft1000_chkcard(dev)) {
 		ft1000_disable_interrupts(dev);
 		return IRQ_HANDLED;
 	}
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
index 9ea32ce..22582be 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
@@ -1465,7 +1465,7 @@ int ft1000_poll(void *dev_id)
 	u16 modulo;
 	u16 portid;
 
-	if (ft1000_chkcard(dev) == FALSE) {
+	if (!ft1000_chkcard(dev)) {
 		pr_debug("failed\n");
 		return -1;
 	}
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/