lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20151018014904.202842320@linuxfoundation.org> Date: Sat, 17 Oct 2015 18:57:12 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Alan Tull <delicious.quinoa@...il.com>, Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>, Jacek Anaszewski <j.anaszewski@...sung.com> Subject: [PATCH 4.1 049/202] leds/led-class: Add missing put_device() 4.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com> commit e5b5a61fcb3743f1dacf9e20d28f48423cecf0c1 upstream. Devices found by class_find_device must be freed with put_device(). Otherwise the reference count will not work properly. Fixes: a96aa64cb572 ("leds/led-class: Handle LEDs with the same name") Reported-by: Alan Tull <delicious.quinoa@...il.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/leds/led-class.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -223,12 +223,15 @@ static int led_classdev_next_name(const { unsigned int i = 0; int ret = 0; + struct device *dev; strlcpy(name, init_name, len); - while (class_find_device(leds_class, NULL, name, match_name) && - (ret < len)) + while ((ret < len) && + (dev = class_find_device(leds_class, NULL, name, match_name))) { + put_device(dev); ret = snprintf(name, len, "%s_%u", init_name, ++i); + } if (ret >= len) return -ENOMEM; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists