linux-kernel - Re: [PATCH] net, can, ti_hecc: fix a run time warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <562492D4.2060600@denx.de>
Date:	Mon, 19 Oct 2015 08:51:00 +0200
From:	Heiko Schocher <hs@...x.de>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-can@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>
Subject: Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.

Hello Marc,

Am 19.10.2015 um 08:34 schrieb Marc Kleine-Budde:
> On 10/19/2015 08:22 AM, Heiko Schocher wrote:
>> This patch fixes a warning in clk_enable by calling
>> clk_prepare_enable instead.
>
> What about the corresponding clk_disable_unprepare()?

Yes, that should be fixed too, do this in a v2, thanks!

bye,
Heiko
>
> Marc
>
>>
>> Signed-off-by: Heiko Schocher <hs@...x.de>
>> ---
>>
>>   drivers/net/can/ti_hecc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
>> index cf345cb..c08e8ea 100644
>> --- a/drivers/net/can/ti_hecc.c
>> +++ b/drivers/net/can/ti_hecc.c
>> @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
>>   	netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
>>   		HECC_DEF_NAPI_WEIGHT);
>>
>> -	clk_enable(priv->clk);
>> +	clk_prepare_enable(priv->clk);
>>   	err = register_candev(ndev);
>>   	if (err) {
>>   		dev_err(&pdev->dev, "register_candev() failed\n");
>>
>
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/