linux-kernel - Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5624A1AF.8080607@atmel.com>
Date:	Mon, 19 Oct 2015 16:54:23 +0900
From:	Tony Cho <tony.cho@...el.com>
To:	Arnd Bergmann <arnd@...db.de>, <gregkh@...uxfoundation.org>
CC:	Stanislav Kholmanskikh <kholmanskikh.s.s@...il.com>,
	Johnny Kim <johnny.kim@...el.com>,
	Rachel Kim <rachel.kim@...el.com>,
	Chris Park <chris.park@...el.com>,
	Glen Lee <glen.lee@...el.com>, Leo Kim <leo.kim@...el.com>,
	<linux-wireless@...r.kernel.org>, <devel@...verdev.osuosl.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try

Hi Arnd Bergmann,

When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs.

Can you consider this patch?

Thanks,

Tony.


On 2015년 10월 17일 05:45, Arnd Bergmann wrote:
> My first attempt to fix the Kconfig logic for wilc1000 was incomplete,
> as it missed the case where SPI is built-in while SDIO is modular
> and wilc1000 is configured as built-in in SPI mode (or vice versa),
> which would still lead to a link failure.
>
> This works around the problem by adding an intermediate Kconfig
> symbol "WILC1000_DRIVER" that controls visibility of the SDIO and
> SPI sub-drivers, so we can control the dependencies better.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 9535ebc5e9cc ("staging/wilc1000: fix Kconfig dependencies")
>
> diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig
> index 59ccecc316df..ee51b4278088 100644
> --- a/drivers/staging/wilc1000/Kconfig
> +++ b/drivers/staging/wilc1000/Kconfig
> @@ -1,14 +1,16 @@
> -config WILC1000
> -	tristate "WILC1000 support (WiFi only)"
> -	depends on !S390
> +config WILC1000_DRIVER
> +	bool "WILC1000 support (WiFi only)"
>   	depends on CFG80211 && WEXT_CORE && INET
> -	depends on MMC || SPI
>   	---help---
>   	  This module only support IEEE 802.11n WiFi.
>   
> +if WILC1000_DRIVER
> +
> +config WILC1000
> +	tristate
> +
>   choice
>           prompt "Memory Allocation"
> -        depends on WILC1000
>           default WILC1000_PREALLOCATE_AT_LOADING_DRIVER
>   
>   config WILC1000_PREALLOCATE_AT_LOADING_DRIVER
> @@ -29,12 +31,12 @@ endchoice
>   
>   choice
>   	prompt "Bus Type"
> -	depends on WILC1000
>   	default WILC1000_SDIO
>   
> -	config WILC1000_SDIO
> +config WILC1000_SDIO
>   	bool "SDIO support"
>   	depends on MMC
> +	select WILC1000
>   	---help---
>   	  This module adds support for the SDIO interface of adapters using
>   	  WILC1000 chipset. The Atmel WILC1000 SDIO is a full speed interface.
> @@ -45,8 +47,9 @@ choice
>   	  To use this interface, pin9 (SDIO_SPI_CFG) must be grounded. Select
>   	  this if your platform is using the SDIO bus.
>   
> -	config WILC1000_SPI
> +config WILC1000_SPI
>   	depends on SPI
> +	select WILC1000
>   	bool "SPI support"
>   	---help---
>   	  This module adds support for the SPI interface of adapters using
> @@ -60,7 +63,7 @@ endchoice
>   
>   config WILC1000_HW_OOB_INTR
>   	bool "Use out of band interrupt"
> -	depends on WILC1000 && WILC1000_SDIO
> +	depends on WILC1000_SDIO
>   	default n
>   	---help---
>   	  This option enables out-of-band interrupt support for the WILC1000
> @@ -68,3 +71,5 @@ config WILC1000_HW_OOB_INTR
>   	  mechanism for SDIO host controllers that don't support SDIO interrupt.
>   	  Select this option If the SDIO host controller in your platform
>   	  doesn't support SDIO time devision interrupt.
> +
> +endif
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/