linux-kernel - Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 11:16:22 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	Daniel Baluta <daniel.baluta@...el.com>,
	driverdev <devel@...verdev.osuosl.org>,
	linux-arm-kernel@...ts.infradead.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The iio dummy code was recently changed to use irq_work_queue, but
> that code is compiled into the kernel only if IRQ_WORK is set, so
> we can get a link error here:
>
> drivers/built-in.o: In function `iio_evgen_poke':
> (.text+0x208a04): undefined reference to `irq_work_queue'
>
> This changes the Kconfig file to match what other drivers do.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")

Acked-by: Daniel Baluta <daniel.baluta@...el.com>

> ---
> Found on ARM randconfig tests
>
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index 6d5b38d69578..9d7f0004d2d7 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
>  source "drivers/staging/iio/trigger/Kconfig"
>
>  config IIO_DUMMY_EVGEN
> -       tristate
> +       tristate
> +       select IRQ_WORK
>
>  config IIO_SIMPLE_DUMMY
>         tristate "An example driver with no hardware requirements"
>
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/