linux-kernel - Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 09:39:13 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Benjamin Cama <benoar@...ka.fr>
Cc:	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	kernel-team@...ts.ubuntu.com
Subject: Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ
 numbers

On Thu, Oct 15, 2015 at 11:03:19AM +0200, Benjamin Cama wrote:
> Hi everyone,
> 
> Le 2015-10-15 08:22, Gregory CLEMENT a écrit :
> > On jeu., oct. 15 2015, Ben Hutchings <ben@...adent.org.uk> wrote:
> >
> >>On Wed, 2015-09-30 at 10:50 +0100, Luis Henriques wrote:
> >>>3.16.7-ckt18 -stable review patch.  If anyone has any objections,
> >>>please let me know.
> >>>
> >>>------------------
> >>>
> >>>From: Benjamin Cama <benoar@...ka.fr>
> >>>
> >>>commit 5be9fc23cdb42e1d383ecc8eae8a8ff70a752708 upstream.
> >>>
> >>>Since v3.18, attempts to deliver IRQ0 are rejected, breaking orion5x.
> >>[...]
> >>
> >>But I don't think this was needed for 3.16-ckt, was it?
> >
> >Indeed it fixes a commit (a71b092a9c68 ("ARM: Convert handle_IRQ to use
> >__handle_domain_irq")) that was introduced in 3.18:
> >
> >git tag --contains a71b092a9c68 | grep "^v3\." | sort | head -1
> >v3.18
> >
> >So please Luis do not apply it on 3.16-ckt unless you already back port
> >the commit a71b092a9c68 ("ARM: Convert handle_IRQ to use
> >__handle_domain_irq") on this branch.
> 
> Indeed it is not completely needed, but to be clear it "just" shifts the
> IRQs by one, so it shouldn't do any harm either. So it is up to you. I would
> understand that you choose not to apply it to be on the safe side. BTW, it
> seems f28d7de is required by my patch, appearing in 3.14; as I don't follow
> kernel development closely, I could not assure you my patch is completly
> safe for 3.16.
>

*Sigh*
Sorry for letting this commit getting in.  I'm reverting it for the next
3.16 kernel release.  Thank you all!

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/