lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Oct 2015 11:17:47 +0200 From: Borislav Petkov <bp@...en8.de> To: Ingo Molnar <mingo@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org> Subject: [PATCH 7/8] kexec/crash: Say which char is the unrecognized From: Borislav Petkov <bp@...e.de> It is helpful when the crashkernel cmdline parsing routines actually say which character is the unrecognized one. Make them do so. Reviewed-by: Dave Young <dyoung@...hat.com> Reviewed-by: Joerg Roedel <jroedel@...e.de> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Andy Lutomirski <luto@...capital.net> Cc: Baoquan He <bhe@...hat.com> Cc: "H. Peter Anvin" <hpa@...or.com> Cc: Ingo Molnar <mingo@...nel.org> Cc: jerry_hoemann@...com Cc: Jiri Kosina <jkosina@...e.cz> Cc: Juergen Gross <jgross@...e.com> Cc: Mark Salter <msalter@...hat.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Vivek Goyal <vgoyal@...hat.com> Cc: WANG Chao <chaowang@...hat.com> Cc: x86-ml <x86@...nel.org> Signed-off-by: Borislav Petkov <bp@...e.de> --- kernel/kexec_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 201b45327804..bd9f8a03cefa 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1149,7 +1149,7 @@ static int __init parse_crashkernel_simple(char *cmdline, if (*cur == '@') *crash_base = memparse(cur+1, &cur); else if (*cur != ' ' && *cur != '\0') { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } @@ -1186,12 +1186,12 @@ static int __init parse_crashkernel_suffix(char *cmdline, /* check with suffix */ if (strncmp(cur, suffix, strlen(suffix))) { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } cur += strlen(suffix); if (*cur != ' ' && *cur != '\0') { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } -- 2.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists