lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Oct 2015 20:27:57 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, benh@...nel.crashing.org, paulus@...ba.org Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH v2] powerpc/prom: Avoid reference to potentially freed memory On Fri, 2015-10-16 at 23:38 +0200, Christophe JAILLET wrote: > of_get_property() is used inside the loop, but then the reference to the > node is dropped before dereferencing the prop pointer, which could by then > point to junk if the node has been freed. > > Instead use of_property_read_u32() to actually read the property > value before dropping the reference. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- > v2: Fix missing '{' > *** COMPILE-TESTED ONLY *** Thanks, this looks good. I'll test it on real hardware. Can you send me a follow up which does the of_get_next_parent() conversion? cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists