linux-kernel - Re: [PATCH] tty/serial: make early console depend on SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4727600.4io7e2HWRP@wuerfel>
Date:	Mon, 19 Oct 2015 14:56:59 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Hurley <peter@...leysoftware.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty/serial: make early console depend on SERIAL_CORE=y

On Sunday 18 October 2015 18:06:48 Paul Gortmaker wrote:
> On an powerpc allmodconfig build, the following is seen:
> 
> paul@...lder:~/git/linux-head$ make O=../ppc-build -j30 > /dev/null
> drivers/built-in.o: In function `.setup_earlycon':
> (.init.text+0x5b00): undefined reference to `.uart_parse_earlycon'
> make[1]: *** [vmlinux] Error 1
> 
> Since uart_parse_earlycon lives in serial_core.c we need to ensure
> it is built in if early console is to be used.

I saw the same thing and came up with a different fix

> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Peter Hurley <peter@...leysoftware.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: linux-serial@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
> 
> [A google shows this cropped up in April of this year; I guess it wasn't
>  completely fixed?
>  http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/336954.html
>  FWIW, I was testing on tty/tty-testing pulled today, from Greg  ]

The new problem was clearly caused by 1d59b382f1c4 ("serial: fsl_lpuart:
add earlycon support"), which selects SERIAL_EARLYCON but not
SERIAL_CORE_CONSOLE.

However, the way I read Peter's patch from the URL you provided,
it seems that it is supposed to work without my patch, so I'm not
sure.

	Arnd

>From 8b8704525b47ba3287de2d7ff89a53e3e335f9d8 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 19 Oct 2015 13:02:08 +0200
Subject: [PATCH] serial: fsl-lpuart: select SERIAL_CORE_CONSOLE

drivers/built-in.o: In function `setup_earlycon':
:(.init.text+0x2c4c): undefined reference to `uart_parse_earlycon'

Signed-off-by: Arnd Bergmann <arnd@...db.de>

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1aec4404062d..f1a4f9eccc44 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1540,6 +1540,7 @@ config SERIAL_FSL_LPUART
 	depends on HAS_DMA
 	select SERIAL_CORE
 	select SERIAL_EARLYCON
+	select SERIAL_CORE_CONSOLE
 	help
 	  Support for the on-chip lpuart on some Freescale SOCs.
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/