linux-kernel - Re: [PATCH] fault-inject: fix inverted interval/probability values in printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umygx3cvmCewGfZQT7jpXFRN6-Xh28EYrMxyAignHXp-sWg@mail.gmail.com>
Date:	Mon, 19 Oct 2015 23:21:36 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Florian Westphal <fw@...len.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dmitry Monakhov <dmonakhov@...nvz.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fault-inject: fix inverted interval/probability values in printk

2015-10-17 17:51 GMT+09:00 Florian Westphal <fw@...len.de>:
> interval displays the probability and vice versa.
>
> Fixes: 6adc4a22f20bb ("fault-inject: add ratelimit option")
> Signed-off-by: Florian Westphal <fw@...len.de>

Looks good to me.

Acked-by: Akinobu Mita <akinobu.mita@...il.com>

Andrew, could you consider to merge this patch to your tree?

> ---
>  lib/fault-inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index f1cdeb0..6a823a5 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
>                 printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
>                        "name %pd, interval %lu, probability %lu, "
>                        "space %d, times %d\n", attr->dname,
> -                      attr->probability, attr->interval,
> +                      attr->interval, attr->probability,
>                        atomic_read(&attr->space),
>                        atomic_read(&attr->times));
>                 if (attr->verbose > 1)
> --
> 2.0.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/