linux-kernel - Re: [PATCH linux-next] soc: ti: use request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56250C74.8010405@oracle.com>
Date:	Mon, 19 Oct 2015 08:29:56 -0700
From:	santosh shilimkar <santosh.shilimkar@...cle.com>
To:	Murali Karicheri <m-karicheri2@...com>, ssantosh@...nel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH linux-next] soc: ti: use request_firmware_direct() as acc
 firmware is optional

On 10/19/2015 8:28 AM, Murali Karicheri wrote:
> On 10/16/2015 10:00 AM, Murali Karicheri wrote:
>> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>>> When firmware image for PDSP firmware is absent in the file system
>>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>>> the default timeout. request_firmware_direct() is to take care of
>>> such optional firmware loading and hence replace the call in the
>>> driver with this API.
>>>
>>> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
>>> ---
>>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>>> b/drivers/soc/ti/knav_qmss_queue.c
>>> index f3a0b6a..89789e2 100644
>>> --- a/drivers/soc/ti/knav_qmss_queue.c
>>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>>> knav_device *kdev,
>>>
>>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>>           if (knav_acc_firmwares[i]) {
>>> -            ret = request_firmware(&fw,
>>> -                           knav_acc_firmwares[i],
>>> -                           kdev->dev);
>>> +            ret = request_firmware_direct(&fw,
>>> +                              knav_acc_firmwares[i],
>>> +                              kdev->dev);
>>>               if (!ret) {
>>>                   found = true;
>>>                   break;
>>>
>> Santosh,
>>
>> If this looks good, could you please send this to linux-next?  Without
>> this, Linux boot will see a pause for about 60 seconds if qmss acc
>> firmware is not present in the file system. So this is a must for next.
>>
> Santosh,
>
> A Gentle ping....
>
Yes I have seen it but it has to wait now. I plan to send that as a fix
as part of 4.4-rcx fixes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/