linux-kernel - [PATCH 0/2] KEYS: Fix crash in GC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151019161248.3215.91824.stgit@warthog.procyon.org.uk>
Date:	Mon, 19 Oct 2015 17:12:48 +0100
From:	David Howells <dhowells@...hat.com>
To:	torvalds@...ux-foundation.org, jmorris@...ei.org
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	dhowells@...hat.com, linux-security-module@...r.kernel.org,
	keyrings@...r.kernel.org, dvyukov@...gle.com
Subject: [PATCH 0/2] KEYS: Fix crash in GC


Hi James, Linus,

Here are two patches, the first of which at least should go upstream
immediately:

 (1) Prevent a user-triggerable crash in the keyrings destructor when a
     negatively instantiated keyring is garbage collected.  I have also seen
     this triggered for user type keys.

 (2) Prevent the user from using requesting that a keyring be created and
     instantiated through an upcall.  Doing so is probably safe since the
     keyring type ignores the arguments to its instantiation function - but we
     probably shouldn't let keyrings be created in this manner.

I'm okay with patch (2) being deferred to the next merge window if we're only
fixing security bugs at this time upstream.

The patches can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-fixes

David
---
David Howells (2):
      KEYS: Fix crash when attempt to garbage collect an uninstantiated keyring
      KEYS: Don't permit request_key() to construct a new keyring


 security/keys/gc.c          |    6 ++++--
 security/keys/request_key.c |    3 +++
 2 files changed, 7 insertions(+), 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/