lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 19 Oct 2015 18:10:54 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	mike.rapoport@...il.com, Larry.Finger@...inger.net,
	florian.c.schilhabel@...glemail.com, carlos@...rcia.org,
	sudipm.mukherjee@...il.com, punitvara@...il.com,
	vthakkar1994@...il.com, jteki@...nedev.com, Julia.Lawall@...6.fr,
	shivanib134@...il.com, luca@...aceresoli.net,
	mahfouz.saif.elyazal@...il.com, cristina.opriceana@...il.com,
	fabf@...net.be, stillcompiling@...il.com,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [PATCH v2 0/3] staging: code cleanup

Hi,

I initially submitted a patch to remove all the explicit boolean comparisons
in rtl8712. These code changes included two instances where braces needed to be
added to clean the output of checkpatch.pl on this patch.

Mike Rapaport correctly pointed out those changes had to go in a separate
patch. Not wanting to only fix those two instances, but cover the whole
rtl8712, I've added a second patch fixing these.

The checkpatch.pl of the second patch included some checks about needing spaces
around operands. Including this fix as well for a nicer checkpatch.pl output.
Plus also making it cover all rtl8712.

In other words, these are a series of recursive cleanup changes.

Thanks for the review Mike,
Luis


Luis de Bethencourt (3):
  staging: rtl8712: Remove boolean comparisons
  staging: rtl8712: braces should be used on all arms
  staging: rtl8712: spaces preferred around operands

 drivers/staging/rtl8712/hal_init.c            |  11 +-
 drivers/staging/rtl8712/ieee80211.c           |  36 ++---
 drivers/staging/rtl8712/mlme_linux.c          |   2 +-
 drivers/staging/rtl8712/os_intfs.c            |   6 +-
 drivers/staging/rtl8712/rtl8712_cmd.c         |  27 ++--
 drivers/staging/rtl8712/rtl8712_efuse.c       | 138 ++++++++++---------
 drivers/staging/rtl8712/rtl8712_io.c          |   6 +-
 drivers/staging/rtl8712/rtl8712_led.c         | 187 +++++++++++++-------------
 drivers/staging/rtl8712/rtl8712_recv.c        |  53 ++++----
 drivers/staging/rtl8712/rtl8712_xmit.c        |  74 +++++-----
 drivers/staging/rtl8712/rtl871x_cmd.c         |  25 ++--
 drivers/staging/rtl8712/rtl871x_eeprom.c      |  22 +--
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 153 +++++++++++----------
 drivers/staging/rtl8712/rtl871x_ioctl_rtl.c   |  53 +++++---
 drivers/staging/rtl8712/rtl871x_ioctl_set.c   |  33 ++---
 drivers/staging/rtl8712/rtl871x_mlme.c        | 144 ++++++++++----------
 drivers/staging/rtl8712/rtl871x_mlme.h        |   2 +-
 drivers/staging/rtl8712/rtl871x_mp.c          |  23 ++--
 drivers/staging/rtl8712/rtl871x_mp_ioctl.c    |  38 +++---
 drivers/staging/rtl8712/rtl871x_pwrctrl.c     |   6 +-
 drivers/staging/rtl8712/rtl871x_recv.c        |  70 +++++-----
 drivers/staging/rtl8712/rtl871x_security.c    | 133 +++++++++---------
 drivers/staging/rtl8712/rtl871x_sta_mgt.c     |  10 +-
 drivers/staging/rtl8712/rtl871x_xmit.c        |  95 ++++++-------
 drivers/staging/rtl8712/usb_halinit.c         |  13 +-
 drivers/staging/rtl8712/usb_intf.c            |  17 +--
 drivers/staging/rtl8712/usb_ops.c             |  20 +--
 drivers/staging/rtl8712/usb_ops_linux.c       |  20 +--
 drivers/staging/rtl8712/xmit_linux.c          |   4 +-
 29 files changed, 753 insertions(+), 668 deletions(-)

-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ