lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Oct 2015 11:40:08 -0700 From: Yang Shi <yang.shi@...aro.org> To: tglx@...utronix.de, bigeasy@...utronix.de, rostedt@...dmis.org Cc: linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org, linaro-kernel@...ts.linaro.org, yang.shi@...aro.org Subject: [PATCH] rt: trace: add rcuidle version macro for preemptirqsoff_hist and hrtimer_interrupt When building rt kernel with IRQSOFF_TRACER enabled but INTERRUPT_OFF_HIST or PREEMPT_OFF_HIST disabled, the below build failure will be triggered: | /home/yshi/linux-rt/kernel/trace/trace_irqsoff.c: In function 'time_hardirqs_on': | /home/yshi/linux-rt/kernel/trace/trace_irqsoff.c:453:2: error: implicit declaration of function 'trace_preemptirqsoff_hist_rcuidle' [-Werror=implicit-function-declaration] | trace_preemptirqsoff_hist_rcuidle(IRQS_ON, 0); | ^ | cc1: some warnings being treated as errors | /home/yshi/linux-rt/scripts/Makefile.build:258: recipe for target 'kernel/trace/trace_irqsoff.o' failed | make[4]: *** [kernel/trace/trace_irqsoff.o] Error 1 | make[4]: *** Waiting for unfinished jobs.... | /home/yshi/linux-rt/scripts/Makefile.build:403: recipe for target 'kernel/trace' failed Because rcuidle version is just defined by TRACE_EVENT when both PREEMPT_OFF_HIST and PREEMPT_OFF_HIST is selected, otherwise just trace_preemptirqsoff_hist is defined as a preprocessor macro. Added rcuidle version macro when the condition is false, and added rcuidle version macro for trace_hrtimer_interrupt_rcuidle even though it is not called by anyone. Signed-off-by: Yang Shi <yang.shi@...aro.org> --- include/trace/events/hist.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/hist.h b/include/trace/events/hist.h index 6122e42..37f6eb8 100644 --- a/include/trace/events/hist.h +++ b/include/trace/events/hist.h @@ -9,6 +9,7 @@ #if !defined(CONFIG_PREEMPT_OFF_HIST) && !defined(CONFIG_INTERRUPT_OFF_HIST) #define trace_preemptirqsoff_hist(a, b) +#define trace_preemptirqsoff_hist_rcuidle(a, b) #else TRACE_EVENT(preemptirqsoff_hist, @@ -33,6 +34,7 @@ TRACE_EVENT(preemptirqsoff_hist, #ifndef CONFIG_MISSED_TIMER_OFFSETS_HIST #define trace_hrtimer_interrupt(a, b, c, d) +#define trace_hrtimer_interrupt_rcuidle(a, b, c, d) #else TRACE_EVENT(hrtimer_interrupt, -- 2.0.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists