linux-kernel - Re: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151019192003.GB4400@redhat.com>
Date:	Mon, 19 Oct 2015 17:20:03 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	David Ahern <dsahern@...il.com>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Hitoshi Mitake <mitake@....info.waseda.ac.jp>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine_str'

Em Mon, Oct 19, 2015 at 09:09:32PM +0200, Ingo Molnar escreveu:
> 
> * Arnaldo Carvalho de Melo <acme@...hat.com> wrote:
> 
> > Em Mon, Oct 19, 2015 at 04:54:47PM -0200, Arnaldo Carvalho de Melo escreveu:
> > > Em Mon, Oct 19, 2015 at 07:34:46AM -0600, David Ahern escreveu:
> > > > On 10/19/15 2:04 AM, Ingo Molnar wrote:
> > > > >@@ -128,7 +128,7 @@ static void __bench_mem_routine(struct bench_mem_info *info, int r_idx, size_t l
> > > > >  	double result_bps = 0.0;
> > > > >  	u64 result_cycles = 0;
> > > > >
> > > > >-	printf("Routine %s (%s)\n", r->name, r->desc);
> > > > >+	printf("routine %s (%s)\n", r->name, r->desc);
> > > > >
> > > > >  	if (bench_format == BENCH_FORMAT_DEFAULT)
> > > > >  		printf("# Copying %s Bytes ...\n\n", length_str);
> > > > 
> > > > Seems like 'R' is more appropriate here.
> > > 
> > > Right, changed it.
> > 
> > And then, he does that on a later patch, duh.
> 
> Yeah, indeed - I messed that up: tried to introduce __unused but noticed during 
> development and testing on other distros that '__unused' is way too crowded a 
> namespace (various fields in random headers are named like that), so after a bit 
> of a fight with those headers I changed it back to __maybe_unused ... but the 
> original change slipped into the series.
> 
> Do you want me to resend the series to fix this and the other problems David and 
> you noticed?

No problem, I fixed it all already :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/