linux-kernel - Re: [PATCH] fpga: zynq-fpga: Fix unbalanced clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAtXAHdpzhM=WSL30tJBJF=+4pho1eqaPbz0Nx51BFxgDLya7g@mail.gmail.com>
Date:	Mon, 19 Oct 2015 13:29:52 -0700
From:	Moritz Fischer <moritz.fischer@...us.com>
To:	Alan Tull <atull@...nsource.altera.com>
Cc:	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.com,
	Moritz Fischer <moritz.fischer@...us.com>
Subject: Re: [PATCH] fpga: zynq-fpga: Fix unbalanced clock handling

On Mon, Oct 19, 2015 at 1:22 PM, Moritz Fischer
<moritz.fischer@...us.com> wrote:
> This commit fixes the unbalanced clock handling, where
> a failed probe would leave the clock with a prepare count of -1.

My English is broken, and it should've said enable count, will
resubmit ...  Sorry for the noise
>
> Reported-by: Josh Cartwright <joshc@...com>
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
> ---
>  drivers/fpga/zynq-fpga.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 103303c..617d382 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -487,7 +487,7 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>                                 &zynq_fpga_ops, priv);
>         if (err) {
>                 dev_err(dev, "unable to register FPGA manager");
> -               clk_disable_unprepare(priv->clk);
> +               clk_unprepare(priv->clk);
>                 return err;
>         }
>
> @@ -502,7 +502,7 @@ static int zynq_fpga_remove(struct platform_device *pdev)
>
>         priv = platform_get_drvdata(pdev);
>
> -       clk_disable_unprepare(priv->clk);
> +       clk_unprepare(priv->clk);
>
>         return 0;
>  }
> --
> 2.6.1
>

Moritz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/