linux-kernel - Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2015 06:07:01 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Liviu Dudau <Liviu.Dudau@....com>
Cc:	kbuild-all@...org, David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Mark Yao <mark.yao@...k-chips.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Russell King <rmk+kernel@....linux.org.uk>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-rockchip <linux-rockchip@...ts.infradead.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the
 generic drm_of_component_probe()

Hi Liviu,

[auto build test WARNING on drm/drm-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Liviu-Dudau/drm-Introduce-generic-probe-function-for-component-based-masters/20151019-231229
config: arm-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/armada/armada_drv.c: In function 'armada_drm_probe':
>> drivers/gpu/drm/armada/armada_drv.c:291:4: warning: passing argument 2 of 'component_match_add' from incompatible pointer type
       component_match_add(&pdev->dev, match, compare_dev_name,
       ^
   In file included from drivers/gpu/drm/armada/armada_drv.c:9:0:
   include/linux/component.h:36:6: note: expected 'struct component_match **' but argument is of type 'struct component_match *'
    void component_match_add(struct device *, struct component_match **,
         ^
>> drivers/gpu/drm/armada/armada_drv.c:304:6: warning: passing argument 2 of 'armada_add_endpoints' from incompatible pointer type
         armada_add_endpoints(&pdev->dev, match,
         ^
   drivers/gpu/drm/armada/armada_drv.c:247:13: note: expected 'struct component_match **' but argument is of type 'struct component_match *'
    static void armada_add_endpoints(struct device *dev,
                ^

vim +/component_match_add +291 drivers/gpu/drm/armada/armada_drv.c

   285			char **devices = pdev->dev.platform_data;
   286			struct device_node *port;
   287			struct device *d;
   288			int i;
   289	
   290			for (i = 0; devices[i]; i++)
 > 291				component_match_add(&pdev->dev, match, compare_dev_name,
   292						    devices[i]);
   293	
   294			if (i == 0) {
   295				dev_err(&pdev->dev, "missing 'ports' property\n");
   296				return -ENODEV;
   297			}
   298	
   299			for (i = 0; devices[i]; i++) {
   300				d = bus_find_device_by_name(&platform_bus_type, NULL,
   301							    devices[i]);
   302				if (d && d->of_node) {
   303					for_each_child_of_node(d->of_node, port)
 > 304						armada_add_endpoints(&pdev->dev, match,
   305								     port);
   306				}
   307				put_device(d);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (53739 bytes)