linux-kernel - Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1445297565.2561.8.camel@decadent.org.uk>
Date:	Tue, 20 Oct 2015 00:32:45 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Cc:	stable@...r.kernel.org, Azael Avalos <coproscefalo@...il.com>,
	Darren Hart <dvhart@...ux.intel.com>
Subject: Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on
 some toshiba models

On Sat, 2015-10-17 at 18:55 -0700, Greg Kroah-Hartman wrote:
> 4.2-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Azael Avalos <coproscefalo@...il.com>
> 
> commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream.
> 
> Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
> for keymap choosing") changed the *setup_keyboard function to query for
> the Hotkey Event Type to help choose the correct keymap, but turns out
> that here are certain Toshiba models out there not implementing this
> feature, and thus, failing to continue the input device registration and
> leaving such laptops without hotkey support.
> 
> This patch changes such check, and instead of returning an error if
> the Hotkey Event Type is not present, we simply inform userspace about it,
> changing the message printed from err to notice, making the function
> responsible for registering the input device to continue.
[...]

But then this function proceeds without events_type being initialised
at all, with unpredictable results.  This doesn't look like a proper
 fix.

Ben.

-- 
Ben Hutchings
The first rule of tautology club is the first rule of tautology club.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)