linux-kernel - Re: [PATCH 5/9] clocksource/drivers/h8300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fmirvx5.wl-ysato@users.sourceforge.jp>
Date:	Tue, 20 Oct 2015 13:44:22 +0900
From:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org, mingo@...nel.org,
	Alexey Klimov <alexey.klimov@...aro.org>,
	uclinux-h8-devel@...ts.sourceforge.jp (moderated list:H8/300
	ARCHITECTURE)
Subject: Re: [PATCH 5/9] clocksource/drivers/h8300_*: Remove unneeded memset()s

On Tue, 20 Oct 2015 05:59:24 +0900,
Daniel Lezcano wrote:
> 
> From: Alexey Klimov <alexey.klimov@...aro.org>
> 
> Memory for timer16_priv, timer8_priv and tpu_priv structs is
> allocated by devm_kzalloc() in corresponding probe functions
> of drivers.
> No need to zero it one more time.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
Acked-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>

> ---
>  drivers/clocksource/h8300_timer16.c | 1 -
>  drivers/clocksource/h8300_timer8.c  | 1 -
>  drivers/clocksource/h8300_tpu.c     | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/clocksource/h8300_timer16.c b/drivers/clocksource/h8300_timer16.c
> index 82941c1..0e076c6 100644
> --- a/drivers/clocksource/h8300_timer16.c
> +++ b/drivers/clocksource/h8300_timer16.c
> @@ -153,7 +153,6 @@ static int timer16_setup(struct timer16_priv *p, struct platform_device *pdev)
>  	int ret, irq;
>  	unsigned int ch;
>  
> -	memset(p, 0, sizeof(*p));
>  	p->pdev = pdev;
>  
>  	res[REG_CH] = platform_get_resource(p->pdev,
> diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c
> index f9b3b70..44375d8 100644
> --- a/drivers/clocksource/h8300_timer8.c
> +++ b/drivers/clocksource/h8300_timer8.c
> @@ -215,7 +215,6 @@ static int timer8_setup(struct timer8_priv *p,
>  	int irq;
>  	int ret;
>  
> -	memset(p, 0, sizeof(*p));
>  	p->pdev = pdev;
>  
>  	res = platform_get_resource(p->pdev, IORESOURCE_MEM, 0);
> diff --git a/drivers/clocksource/h8300_tpu.c b/drivers/clocksource/h8300_tpu.c
> index 64195fd..5487410 100644
> --- a/drivers/clocksource/h8300_tpu.c
> +++ b/drivers/clocksource/h8300_tpu.c
> @@ -123,7 +123,6 @@ static int __init tpu_setup(struct tpu_priv *p, struct platform_device *pdev)
>  {
>  	struct resource *res[2];
>  
> -	memset(p, 0, sizeof(*p));
>  	p->pdev = pdev;
>  
>  	res[CH_L] = platform_get_resource(p->pdev, IORESOURCE_MEM, CH_L);
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/