linux-kernel - Re: [PATCH] m5602: correctly check failed thread creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5625F865.9080400@redhat.com>
Date:	Tue, 20 Oct 2015 10:16:37 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Insu Yun <wuninsu@...il.com>, erik.andren@...il.com,
	mchehab@....samsung.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu,
	changwoo@...ech.edu
Subject: Re: [PATCH] m5602: correctly check failed thread creation

Hi,

On 19-10-15 17:24, Insu Yun wrote:
> Since thread creation can be failed, check return value of
> kthread_create and handle an error.
>
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>   drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
> index bf6b215..76b40d1 100644
> --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
> +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
> @@ -221,6 +221,10 @@ int s5k83a_start(struct sd *sd)
>   	   to assume that there is no better way of accomplishing this */
>   	sd->rotation_thread = kthread_create(rotation_thread_function,
>   					     sd, "rotation thread");
> +	if (IS_ERR(sd->rotation_thread)) {
> +		err = PTR_ERR(sd->rotation_thread);
> +		goto fail;
> +	}

There is no need to use a goto here you can simply directly return
the error.

>   	wake_up_process(sd->rotation_thread);
>
>   	/* Preinit the sensor */
> @@ -234,9 +238,11 @@ int s5k83a_start(struct sd *sd)
>   				data[0]);
>   	}
>   	if (err < 0)
> -		return err;
> +		goto fail;

No need for introducing a goto here either.

>
>   	return s5k83a_set_led_indication(sd, 1);
> +fail:
> +	return err;
>   }
>
>   int s5k83a_stop(struct sd *sd)

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/