linux-kernel - Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151021062841.GB30332@hr-amur2>
Date:	Wed, 21 Oct 2015 14:28:41 +0800
From:	Huang Rui <ray.huang@....com>
To:	Jean Delvare <jdelvare@...e.de>
CC:	Guenter Roeck <linux@...ck-us.net>,
	kbuild test robot <lkp@...el.com>,
	Yuanhan Liu <yuanhan.liu@...ux.intel.com>,
	Fengguang Wu <fengguang.wu@...el.com>, <kbuild-all@...org>,
	Borislav Petkov <bp@...e.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...capital.net>,
	Andreas Herrmann <herrmann.der.user@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	<lm-sensors@...sensors.org>, <linux-kernel@...r.kernel.org>,
	<x86@...nel.org>,
	Andreas Herrmann <herrmann.der.user@...glemail.com>,
	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>,
	Borislav Petkov <bp@...en8.de>, Aaron Lu <aaron.lu@...el.com>,
	Tony Li <tony.li@....com>
Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit
 accumulated power

Hi Jean,

On Wed, Oct 21, 2015 at 08:05:20AM +0200, Jean Delvare wrote:
> Hi Rui,
> 
> On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote:
> > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote:
> > > On 10/20/2015 07:40 PM, Huang Rui wrote:
> > > >>>Thanks to report this issue. :)
> > > >>>The root cause is that the test config doesn't enable
> > > >>>CONFIG_CPU_SUP_AMD.
> > > >>>
> > > >>>How about below fix:
> > > >>>
> > > >>
> > > >>Guess you don't have a choice.
> > > >>
> > > >
> > > >Yes, if I use test config, fam15h_power isn't chosen. :)
> > > >
> > > >And if I use the "select" flag like below, fam15h_power can be built
> > > >successfully.
> > > >
> > > That is another possibility, though that isn't how CPU_SUP_AMD
> > > is handled by its other users. Matter of philosophy, I guess.
> > 
> > Err, sorry. Could you please point out the other possibility?
> 
> Both possibilities came from you. First one is to use "depends", second
> one is to use "select".
> 
> As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE,
> AMD_NB) use "depends" so you should do the same for consistency.
> 

Thanks to clarify it. I will use "depends" at next version.

Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/